[PATCH] D81743: InlineCostAnnotationPrinterPass - Introducing the pass

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D81743#2095745 <https://reviews.llvm.org/D81743#2095745>, @knaumov wrote:

> - Refactored the comment For now, my view of the pass is to be able to tell what optimizations are seen and predicted by InlineCost. E.g. is a follow-up patch D81024 <https://reviews.llvm.org/D81024> which enables printing of constants to which the instruction will be simplified. For now, if you've written a simplification for InlineCost that constant-folds some sequence of instructions, you have no way of writing test for it except by setting the inline threshold so low, so the fact of simplification will inline the method. This pass provides an easy way to see such cases directly. Also, the fact of simplification itself is independent of InlineParams, so the pass would work as expected.


Ah, OK! This description helps a lot, thank you!

If that's the case, could you update the patch description and the pass documentation to specify this is currently for tests, and the FIXME - basically, the FIXME is only if we want to scope this to more than tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81743/new/

https://reviews.llvm.org/D81743