[PATCH] D81908: [MIPS] Fix incorrect relocations of instruction
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 16 04:58:18 PDT 2020
atanasyan added a comment.
Does this patch depend on D81919 <https://reviews.llvm.org/D81919>?
================
Comment at: llvm/test/MC/Mips/reloc-implicit-constraints-error.s:9
+
+.globl end
+ ori $4, $4, start # O32: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
----------------
Do you need this line in the test?
================
Comment at: llvm/test/MC/Mips/reloc-implicit-constraints-error.s:10
+.globl end
+ ori $4, $4, start # O32: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
+ # N64: [[@LINE-1]]:{{[0-9]+}}: error: should use explicit constraints
----------------
You do not need to use two separate check prefixes O32 and N64:
```
ori $4, $4, start # CHECK: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
```
================
Comment at: llvm/test/MC/Mips/reloc-implicit-constraints-error.s:16
+
+ addiu $4, $4, start # O32: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
+ # N64: [[@LINE-1]]:{{[0-9]+}}: error: should use explicit constraints
----------------
Do you need to check both `ori` and `addiu` instructions?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81908/new/
https://reviews.llvm.org/D81908
More information about the llvm-commits
mailing list