[PATCH] D81915: [ObjectYAML][DWARF] Let writeVariableSizedInteger() return Error.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:133
+              Descriptor.Address, Range.AddrSize, OS, DI.IsLittleEndian))
+        return Err;
+      cantFail(writeVariableSizedInteger(Descriptor.Length, Range.AddrSize, OS,
----------------
jhenderson wrote:
> Perhaps here and at similar points, it might be worth adding additional context to the message, to address your problem. There are examples of this in various places, such as llvm-readobj, I believe.
I'm not sure if I'm doing it in the right way. I added one helper function `errorWithContext()` which helps add additional information to the error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81915/new/

https://reviews.llvm.org/D81915