[PATCH] D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue

Leslie Zhai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 04:24:24 PDT 2020


xiangzhai added a comment.

DEBUG patch:

  diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp
  index a050671..a0810d4 100644
  --- a/llvm/lib/MC/MCParser/AsmParser.cpp
  +++ b/llvm/lib/MC/MCParser/AsmParser.cpp
  @@ -1406,6 +1406,7 @@ bool AsmParser::parseExpression(const MCExpr *&Res, SMLoc &EndLoc) {
     int64_t Value;
     if (Res->evaluateAsAbsolute(Value))
       Res = MCConstantExpr::create(Value, getContext());
  +  printf("%s:%d Value: %d\n", __func__, __LINE__, Value);
   
     return false;
   }

Wrong `Value` 0?

  $ ./build/bin/clang -fPIC -c ./llvm/test/MC/Mips/reloc-directive-bad-n64.s -o t.llvm.o
  
  .. generic integer expression
  parseExpression:1409 Value: 0
  ./llvm/test/MC/Mips/reloc-directive-bad-n64.s:7:25: warning: should use explicit constraints!
         daddiu $t9, $ra, main - .    # CHECK: :[[@LINE]]:25: warning: should use explicit constraints!
                          ^
  <unknown>:0: warning: should use explicit constraints!
  parseExpression:1409 Value: 0


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81919/new/

https://reviews.llvm.org/D81919





More information about the llvm-commits mailing list