[PATCH] D81835: [SimplifyCFG] Fix inconsistency in block size assessment for threading

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked 2 inline comments as done.
mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2199
+    // accounted in block's size.
+    if (!isa<PHINode>(I))
+      ++Size;
----------------
xbolva00 wrote:
> Skip llvm.assume too?
Not sure if it makes sense, given that this restriction's point (or at least one of them) is to save compile time.


================
Comment at: llvm/test/Transforms/PhaseOrdering/inlining-alignment-assumptions.ll:17
 
 define void @caller1(i1 %c, i64* align 1 %ptr) {
 ; ASSUMPTIONS-OFF-LABEL: @caller1(
----------------
nikic wrote:
> This test should be adjusted with extra store -1 to retain the previous behavior, otherwise it doesn't show what it's supposed to be showing.
Ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81835/new/

https://reviews.llvm.org/D81835