[PATCH] D81915: [ObjectYAML][DWARF] Let writeVariableSizedInteger() return Error.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing created this revision.
Higuoxing added reviewers: jhenderson, grimar, MaskRay.
Herald added subscribers: llvm-commits, hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
Higuoxing added a comment.

I think the error message "invalid integer write size" makes little sense here. If multiple sections are involved, it's hard to tell which section contains the invalid value. I'm still thinking about improving it.


This patch helps change the return type of `writeVariableSizedInteger()` from `void` to `Error`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81915

Files:
  llvm/lib/ObjectYAML/DWARFEmitter.cpp
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-ranges.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81915.270982.patch
Type: text/x-patch
Size: 10595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200616/d4963dd5/attachment.bin>