[PATCH] D81879: [CGP] Reset the debug location when promoting trunc(s)

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 14:21:15 PDT 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm. I had a look at the other TypePromotionActions in CodeGenPrepare: I think it'd be better to default to these /not/ carrying over debug locations, even though in some cases it would be appropriate to do so (e.g. if the instruction reordering is block-local), just because there's so much cross-BB movement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81879/new/

https://reviews.llvm.org/D81879





More information about the llvm-commits mailing list