[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit for TempFile

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a subscriber: inglorion.
amccarth added a comment.

That commit (which was reviewed here https://reviews.llvm.org/D48051) suggests this wasn't about the occasional temp file not getting deleted.  It was to work around surprising behavior on Windows when a temp file is mapped into memory, which, as I recall, was the underlying cause in what appeared to be cache corruption for LTO.

I think it best if @pcc and/or @inglorion weigh in.

BTW, is it common to create temp files on a network drive?  Is that done in distributed build systems?  For a single-machine build, it would seem counter productive to use a network drive for a temp file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803