[PATCH] D80855: [lld-macho] Support non-pcrel section relocs

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/test/MachO/relocations.s:36
   mov $1, %rdi # stdout
-  leaq _str(%rip), %rsi
+  leaq _str(%rip), %rsi # This generates a pcrel symbol relocation
   mov $21, %rdx # length of str
----------------
MaskRay wrote:
> Rather than saying "This generates a pcrel symbol relocation",
> it may be more helpful to just write the relocation type.
The type doesn't indicate whether it's pcrel or symbol vs section, though, so those bits of info are still necessary. But good point about greppability, I'll add in the type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80855/new/

https://reviews.llvm.org/D80855