[PATCH] D81472: [Matrix] Update load/store intrinsics.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1465
+               WriteOnly<ArgIndex<1>>, ImmArg<ArgIndex<3>>,
+               ImmArg<ArgIndex<4>>, ImmArg<ArgIndex<5>>]>;
 
----------------
anemet wrote:
> sstefan1 wrote:
> > jdoerfert wrote:
> > > fhahn wrote:
> > > > jdoerfert wrote:
> > > > > [Drive by][unrelated] I think we should add `nocapture` to the ptr argument and `nosync` to all of them (until we have the white/blacklist for intrinsics with sensible defaults).
> > > > Thanks for pointing that out. There are just too many attributes to keep track of. I wish we had some kind of attribute 'group' to say: just reads/write from the pointer, no capture and other stuff
> > > We (@sstefan1) proposed a whitelist and blacklist approach for intrinsics before. Hasn't gone anywhere yet. For the OpenMP runtime functions we actually have such attribute groups. Either way is better than what we do so far.
> > I will try to get back to that soon.
> Has this been addressed?
This is unrelated and should not block the patch. Eventually we want easier attribute handling for intrinsics but we are still working on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81472/new/

https://reviews.llvm.org/D81472