[PATCH] D81326: lld: improve the `-arch` handling for MachO

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 14:21:03 PDT 2020


int3 added a comment.

Hey @compnerd, didn't realize that this diff would mean we needed to specify `-arch` in all our tests... I tried to remove that in D81802: [lld-macho] No need to explicitly specify -arch in tests <https://reviews.llvm.org/D81802> but it appears that `REQUIRES: x86` tests still run on non-x86 machines, because (we think) the `REQUIRES` line is about what targets are supported by the LLVM that we're building, and not what the host machine is running. Looking at lld-ELF and ld64, it seems that they both try to infer the architecture from the input object files, so we should probably implement that at some point. But in the meantime, could we revert to the old behavior of defaulting to `x86_64` regardless of the default target triple?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81326/new/

https://reviews.llvm.org/D81326





More information about the llvm-commits mailing list