[PATCH] D81301: [X86] Emit two-byte NOP when possible

Mon Jun 15 13:14:20 PDT 2020

craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1358
+      // This is only for 32-bit targets, when using /arch:IA32 or /arch:SSE.
+      bool LegacyNop =
+          Subtarget->is32Bit() && Subtarget->isTargetWindowsMSVC() &&
----------------
How much code would it be to just emit the legacy nop directly here and call emitNop for the other cases? Rather than pushing this legacy nop concept into emitNop?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81301/new/

https://reviews.llvm.org/D81301