[PATCH] D81447: [llvm] Added support for stand-alone cmake object libraries.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D81447#2093555 <https://reviews.llvm.org/D81447#2093555>, @beanz wrote:

> It is kinda bad form to merge a change that has unaddressed feedback.


Apologies again, I didn't see your feedback after the earlier LGTM, until after I pushed. There seems to be a random delay between Phabricator comments being posted, and emails being sent. I suppose I could refresh more actively the Phabricator page.

> I have significant concerns about this change, and I think this change is being made to workaround incorrect implementation that landed in https://reviews.llvm.org/D80579.
> 
> We should discuss the problems with this change before any further work goes in on this.
> 
> -Chris




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81447/new/

https://reviews.llvm.org/D81447