[PATCH] D81863: [gicombiner] Allow generated combiners to store additional members

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 12:37:57 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp:58
+protected:
+  CombinerHelper &Helper;
+
----------------
arsenm wrote:
> Should every combiner just get this by default? I would think every combiner pass would use this, and this just adds more boilerplate to every target?
I guess this does let you choose your member name


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81863/new/

https://reviews.llvm.org/D81863





More information about the llvm-commits mailing list