[PATCH] D81447: [llvm] Added support for stand-alone cmake object libraries.

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 12:37:51 PDT 2020


beanz added a reviewer: compnerd.
beanz added a comment.

It is kinda bad form to merge a change that has unaddressed feedback.

I have significant concerns about this change, and I think this change is being made to workaround incorrect implementation that landed in https://reviews.llvm.org/D80579.

We should discuss the problems with this change before any further work goes in on this.

-Chris


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81447/new/

https://reviews.llvm.org/D81447





More information about the llvm-commits mailing list