[PATCH] D81764: [flang] Add the Mangler module to flang lowering

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 10:23:40 PDT 2020


sameeranjoshi added a comment.

In D81764#2093014 <https://reviews.llvm.org/D81764#2093014>, @schweitz wrote:

> Unit tests on internal naming don't have that dependency. But they do have a dependency on the fixes included in this patch.


I don't think they have dependency, the tests are updated.

IIRC, first the bugs were found using tests and later changes were made to code in fir-dev.
Here's one[1] such I recall

[1]https://github.com/flang-compiler/f18-llvm-project/pull/98/commits/0d0a47020f233f5ea7c10ffb6cd24fb6b9da7b46


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81764/new/

https://reviews.llvm.org/D81764





More information about the llvm-commits mailing list