[PATCH] D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 10:23:40 PDT 2020


thakis added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/TargetInfo/WebAssemblyTargetInfo.cpp:40
+#define GET_INSTRINFO_ENUM 1
+#include "WebAssemblyGenInstrInfo.inc"
----------------
This is a bit awkward. It makes WebAssembly the only target that has its TargetInfo dir depend on a llvm-tblgen generated file. It doesn't cause actual issues, but it's irregular.

Make of this what you will :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81704/new/

https://reviews.llvm.org/D81704





More information about the llvm-commits mailing list