[PATCH] D81801: Remove KillTheDoctor

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 09:13:39 PDT 2020


pcc added a comment.

> Win32 has an API for disabling error reporting which is already implemented in sys::DisableSystemDialogsOnCrash(), gtest and relevant test cases such as compiler-rt/test/asan/TestCases/ill.cpp.

But not by the CFI tests. I suspect that this change will cause some of the CFI tests to start to fail (if they are unsupported on your machine, you might not see the failure). What is the output of running check-cfi with this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81801/new/

https://reviews.llvm.org/D81801





More information about the llvm-commits mailing list