[PATCH] D81498: [Matrix] Preserve volatile when loading loads/stores.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 15 08:41:07 PDT 2020
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1220
MatrixTy A =
- loadMatrix(APtr, LShape, Builder.getInt64(I), Builder.getInt64(K),
- {TileR, TileM}, EltType, Builder);
+ loadMatrix(APtr, false, LShape, Builder.getInt64(I),
+ Builder.getInt64(K), {TileR, TileM}, EltType, Builder);
----------------
LuoYuanke wrote:
> Why we set volatile as false? Is it possible that the original load instruction is volatile load?
> Do we allow fusion if the load and store instruction is volatile?
Yes indeed! I wanted to share the code ASAP, fixed now (with additional test case)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81498/new/
https://reviews.llvm.org/D81498
More information about the llvm-commits
mailing list