[PATCH] D81541: [ObjectYAML][DWARF] Implement the .debug_addr section.

Mon Jun 15 04:51:53 PDT 2020

grimar accepted this revision.
grimar added a comment.

LGTM

================
Comment at: llvm/lib/ObjectYAML/DWARFYAML.cpp:205
+    IO &IO, DWARFYAML::AddrTableEntry &AddrTable) {
+  IO.mapOptional("Format", AddrTable.Format, dwarf::DWARF32);
+  IO.mapOptional("Length", AddrTable.Length);
----------------
jhenderson wrote:
> grimar wrote:
> > Hmmm. I guess `DWARF64` would be more common?
> You'd guess wrong :)
> 
> DWARF64 generation is only just starting to be supported in MC. DWARF32 is the "standard" format, and being more compact, is used, unless the DWARF section is too big to fit in the 32-bit format. That is very unlikely to ever happen in a current real-world case.
Ah, right. I think I read it as object format and not as dwarf format.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81541/new/

https://reviews.llvm.org/D81541