[PATCH] D81541: [ObjectYAML][DWARF] Implement the .debug_addr section.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml:243
+      SegmentSelectorSize: 0x00
+      Entries:             []
+
----------------
jhenderson wrote:
> Higuoxing wrote:
> > jhenderson wrote:
> > > You need a test case each for missing the version and address size fields.
> > `Version` is a required field, do we still need to test it here?
> Right, but how do you show that `Version` is required? You need a test showing that it is, i.e. that you get an error message if the `Version` is unspecified.
I added one test case (g) for missing 'Version' :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81541/new/

https://reviews.llvm.org/D81541