[PATCH] D81826: [DWARFYAML][debug_abbrev] Make the abbreviation code optional.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The premerge bot is complaining about several failing tests in ObjectYAML. You should probably investigate those.

Edit to add: oh I see you've spotted that already.



================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:95
+    AbbrevCode =
+        AbbrevDecl.Code ? (uint64_t) * (AbbrevDecl.Code) : AbbrevCode + 1;
+    encodeULEB128(AbbrevCode, OS);
----------------
grimar wrote:
> Looks unformatted.
> 
> It is also more common to write in the following way I think:
> 
> ```
> (uint64_t)*AbbrevDecl.Code
> ```
> 
> (i.e. no brackets around the `AbbrevDecl.Code`)
Something looks off in this formatting. Did you run clang-format and/or mean `(uint64_t)(*AbbrevDecl.Code)` perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81826/new/

https://reviews.llvm.org/D81826