[PATCH] D71742: Added intrinsics for access to FP environment

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff marked 3 inline comments as done.
sepavloff added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:649-651
+  def int_get_fpenv     : Intrinsic<[], [llvm_ptr_ty]>;
+  def int_set_fpenv     : Intrinsic<[], [llvm_ptr_ty]>;
+  def int_reset_fpenv   : Intrinsic<[], []>;
----------------
arsenm wrote:
> Using a pointer for this is problematic, and one with a hardcoded 0 address space doubly so
Changed type to `llvm_anyptr_ty`, which must support arbitrary address spaces.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:652
+  def int_reset_fpenv   : Intrinsic<[], []>;
 }
 
----------------
jdoerfert wrote:
> [Drive by][Unrelated] `nosync`, `nofree` missing. Should be `readonly` or `writeonly` I suspect. Arguments can be `nocapture`.
Fixed, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71742/new/

https://reviews.llvm.org/D71742