[PATCH] D81829: [LangRef] Element-wise Integral Reduction Intrinsics

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 02:08:37 PDT 2020


nikic added a reviewer: nikic.
nikic added a comment.

I find the naming of these intrinsics somewhat unintuitive. My first association with `llvm.reduce.smax` is that this is the non-experimental version of `llvm.experimental.vector.reduce.smax`, because reduction (to me) carries a strong vector reduction connotation. I can still see how these might be "reductions" for min/max (in which case I would expect the intrinsics to be variadic though), but not seeing the analogy at all for abs().

I would suggest to instead call these just `llvm.smax`, `llvm.abs` etc, which seems more in line with existing integer intrinsic names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81829/new/

https://reviews.llvm.org/D81829





More information about the llvm-commits mailing list