[PATCH] D81605: [IR] Add missing GlobalAlias copying of ThreadLocalMode attribute
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 15 01:36:14 PDT 2020
hans accepted this revision.
hans added a comment.
In D81605#2088652 <https://reviews.llvm.org/D81605#2088652>, @tejohnson wrote:
> LGTM. If @hans has any comments they can be addressed in a follow on change.
When I added the TLS mode attribute, it only applied to GlobalVariables. Later, in 59f7eba2b546e4118434b0ea9de5e08c316a64b1, it was moved to also apply to aliases, but it seems that commit forgot to move the attribute copying. The current patch looks like a good fix to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81605/new/
https://reviews.llvm.org/D81605
More information about the llvm-commits
mailing list