[PATCH] D81667: [RFC, FileCheck] Add precision to format specifier

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I think I agree with your conclusions. More generally, I think we should be permissive, where permissiveness is not going to be surprising (i.e. no explicit format specifier seems reasonable in the general context), and should follow `scanf` style format specifiers where reasonable. If I follow it right, it would therefore be possible to specify a 16-digit hex field with `%.16x`, right? Could you clarify what the motivation of the "with empty expression" bit is for? Is that just because when there is an empty expression, your regex is incorrect, or something else?

The code change in general seems simple enough to support the proposal too, though I haven't reviewed it in detail. I'll wait until you've added documentation/tests etc, so that I can review it all at once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81667/new/

https://reviews.llvm.org/D81667