[PATCH] D81802: [lld-macho] No need to explicitly specify -arch in tests

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 14 15:28:23 PDT 2020


MaskRay accepted this revision as: MaskRay.
MaskRay added a comment.
This revision is now accepted and ready to land.

>   we specify REQUIRES: x86, but REQUIRES: x86_64 doesn't seem to be a valid setting -- but in practice the tests seem to pass on Harbormaster, so I guess it's fine...?

`lld/test/lit.cfg.py` defines:

  llvm_config.feature_config(
      [('--build-mode', {'DEBUG': 'debug'}),
       ('--assertion-mode', {'ON': 'asserts'}),
       ('--targets-built', {'AArch64': 'aarch64',
                            'AMDGPU': 'amdgpu',
                            'ARM': 'arm',
                            'AVR': 'avr',
                            'Hexagon': 'hexagon',
                            'Mips': 'mips',
                            'MSP430': 'msp430',
                            'PowerPC': 'ppc',
                            'RISCV': 'riscv',
                            'Sparc': 'sparc',
                            'WebAssembly': 'wasm',
                            'X86': 'x86'})
       ])

`x86_64` is not a lit feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81802/new/

https://reviews.llvm.org/D81802





More information about the llvm-commits mailing list