[PATCH] D78459: [AVR] Don't adjust for instruction size

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 14 04:17:03 PDT 2020


dylanmckay added a comment.

> Ok, I can add the test case (need to recompile LLVM first). It just seems a bit large to me (over 1000 lines).

That's fine, I've seen many much larger LLVM unit tests (there's one X86 one that's over 32,000 IIRC). Characters are cheap, certainly good price compared to the bugs they guard against.

Thanks again for the patch @aykevl

> It's not the cleanest code, but feel free to use it for the integration test. Testing AVR compiler-rt (even if not all the tests pass yet) can be a good way to ensure working builtins won't break.

That's very neat, plus the code is in-tree, which is even better. It would be nice to add to the integration tests - ideally, we can wire extra tests up easy enough. I will have to a deeper look into it and wire it up, also set up 24/7 automation with the suite itself. I'm looking into writing a Ruby script for LLVM Phabricator (I would be able to merge this patches much much quicker if they can be automatically validated/(read: validated without recompiling LLVM manually)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78459/new/

https://reviews.llvm.org/D78459





More information about the llvm-commits mailing list