[PATCH] D80769: [WebAssembly] Adding 64-bit versions of all load & store ops.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td:371
                          "memory.size\t$dst, $flags", "memory.size\t$flags",
-                         0x3f>,
-                       Requires<[HasAddr32]>;
+                         0x3f>;
 
----------------
tlively wrote:
> dschuff wrote:
> > Question for the tblgen experts maybe,  if a def has both an instruction definition and a pattern as this one does, does the `Requires` field actually apply to the pattern? Or does  `Requires` only work for freestanding patterns?
> I would have thought that `Requires` should apply to both kinds of patterns. In particular, inheriting it just sets the `Predicates` field in both `Instruction` and `Pattern`. But I read @aheejin's comment above to mean that this doesn't work after all, so perhaps I am wrong.
Yes not sure if it's an intended behavior or a bug of TableGen, but what I observed is predicates only work on patterns and not on definitions. Actually @dschuff confirmed that to me when I was confused and asked him :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80769/new/

https://reviews.llvm.org/D80769