[PATCH] D80769: [WebAssembly] Adding 64-bit versions of all load & store ops.

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.

I think this is good now. If the `Requires` I mentioned above should actually go back in, it can be in a followup CL (presumably where we add MEMORY_SIZE_I64 and friends).



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td:371
                          "memory.size\t$dst, $flags", "memory.size\t$flags",
-                         0x3f>,
-                       Requires<[HasAddr32]>;
+                         0x3f>;
 
----------------
Question for the tblgen experts maybe,  if a def has both an instruction definition and a pattern as this one does, does the `Requires` field actually apply to the pattern? Or does  `Requires` only work for freestanding patterns?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80769/new/

https://reviews.llvm.org/D80769