[PATCH] D81773: [llvmbuild] Allow OptionalLibrary's to be enabled by default and disabled

[Daniel Sanders via Phabricator via llvm-commits]

dsanders created this revision.
dsanders added reviewers: bogner, ddunbar.
Herald added a project: LLVM.
dsanders added a comment.
dsanders updated this revision to Diff 270545.

Just to give you some context and an overview of the direction, we have some hacks we use to make our LLVM dylib smaller by omitting subcomponents of LLVM that we don't actually use in practice. This is part of a small series of patches to try to eliminate these hacks by rounding out llvmbuild's support for optional libraries. This patch allows libraries to be included by default and optionally disabled, and it will be followed by a small bugfix for --enable-optional-components, and then the addition of an optional_libraries to go with the existing required_libraries.


dsanders added a comment.

Remove a bit of the next patch that snuck into this one while organizing the patches


As part of this, clean up the duplicated code where each writer independently
implemented the effects of --enable-optional-components. Also, clean up the
pseudo-isinstance() in case I find I need to add OptionalLibraryGroup later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81773

Files:
  llvm/test/LLVMBuild/enabled/Input/LLVMBuild.txt
  llvm/test/LLVMBuild/enabled/Input/lib/IR/Function.cpp
  llvm/test/LLVMBuild/enabled/Input/lib/LLVMBuild.txt
  llvm/test/LLVMBuild/enabled/enabled.test
  llvm/test/LLVMBuild/lit.local.cfg
  llvm/utils/llvm-build/llvmbuild/componentinfo.py
  llvm/utils/llvm-build/llvmbuild/main.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81773.270545.patch
Type: text/x-patch
Size: 11055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200612/cfaf952b/attachment-0001.bin>