[PATCH] D81765: Don't hoist very large static allocas to the entry block during inlining

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 15:58:59 PDT 2020


jfb added a comment.

One thing I'd like to make sure we don't break:

  __attribute__((always_inline))
  char *stack_allocate(size_t size) {
    if (size < threshold)
      return alloca(size);
    return malloc(size);
  }

This should always inline. Is it still the case? It turns out that we have Important Code which relies on this...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81765/new/

https://reviews.llvm.org/D81765





More information about the llvm-commits mailing list