[PATCH] D78851: Debug Info Support for Basic Block Sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:215-223
+    //
+    // If the first mention of an argument is in a unique-section basic block,
+    // we cannot assign the CurrentFnBegin label, as it lies in a different
+    // section. For simplicity, we simply ignore such mentions in this code.
     const DILocalVariable *DIVar =
         Entries.front().getInstr()->getDebugVariable();
     if (DIVar->isParameter() &&
----------------
dblaikie wrote:
> Is there a test case covering this? Rough sense of how much this hurts debug info quality?
I am still working on getting a test case for this.  I will iterate on this shortly.


================
Comment at: llvm/test/DebugInfo/X86/basicblock-sections_1.ll:13-16
+; NO-SECTIONS: DW_AT_low_pc     DW_FORM_addr
+; NO-SECTIONS: DW_AT_high_pc    DW_FORM_data4
+; BB-SECTIONS: DW_AT_low_pc     DW_FORM_addr
+; BB-SECTIONS: DW_AT_ranges	DW_FORM_sec_offset
----------------
dblaikie wrote:
> This might be a case where testing the assembly would be appropriate - to check which symbols and symbolic expressions are used for the ranges/high/low rather than only that is "some range".
I have added checks for the assembly.  Please let me know if there is something specific you want to check here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78851/new/

https://reviews.llvm.org/D78851