[PATCH] D81758: [WebAssembly] Handle unstackified TEE dest in ExplicitLocals

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

(I'll use the term "de-stackify" as a verb to avoid confusion).
If fixUnwindMismatches de-stackifies the tee result, does that violate some kind of invariant? is it better to fix it up in fixUnwindMismatches?



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp:277
+        // operand 0 is stackified and operand 1 is not. But it is possible that
+        // operand 0 is unstackified in fixUnwindMismatches function in
+        // CFGStackify pass when a nested try-catch-end is introduced. In this
----------------
does this mean that fixUnwindMismatches makes it unstackified or that it's already unstackified when fixUnwindMismatches runs?
edit:
I think it means the former, so maybe this could say "operand 0 becomes unstackified" instead. I guess this is all because "unstackified" could be a noun or a verb.... thanks English...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81758/new/

https://reviews.llvm.org/D81758