[PATCH] D81760: [WebAssembly] Add warnings for -shared and -pie

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/Driver.cpp:469
+    if (config->shared) {
+      warn("shared libraries are not yet implemented");
+    }
----------------
Since this is just a warning and linker will actual produce a binary.. how about something like like :  "the shared library is not yet stable"?      Or some other wording to that effect.

This wording sounds like it would be hard error and not output anything.


================
Comment at: lld/wasm/Options.td:204
+// Emscripten PIC mode.
+def emscripten_pic: F<"emscripten-pic">,
+  HelpText<"Enable Emscripten-style PIC">;
----------------
I'm a little loath to explicitly call out emscripten.   We could use some term like "experimental" or "v1" or something similar?   

Once argument for this the emscripten ABI is actually quite different to the output of lld.    We use a binaryen transforms which transforms the lld output, for example it internalizes/removes all the GOT imports that lld generates.     


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81760/new/

https://reviews.llvm.org/D81760