[PATCH] D81607: BreakCriticalEdges for callbr indirect dests

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

In D81607#2090510 <https://reviews.llvm.org/D81607#2090510>, @efriedma wrote:

> If the plan is to drop blockaddresses from callbr, then this LGTM.


Disclaimer: I don't plan to rework `callbr`'s operands before landing this. Was that a conditional LGTM?

I would like to resolve @fhahn 's question. TBH, I understand what a critical edge is, but I don't understand why splitting them is necessary?  I assume there's something important @fhahn was alluding to, but I'm not sure precisely what, and I would like to make sure everyone's happy with this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81607/new/

https://reviews.llvm.org/D81607