[PATCH] D81106: [PowerPC][NFC] Don't need to and instruction with inverse of mask.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 13:08:19 PDT 2020


MaskRay added a comment.

Shall we mask out the bits (keep existing `(read32(loc) & ~mask)`)? If other relocations don't behave this way, let's fix it. Writing zeros to the bits is a courtesy of the assembly but should we make use of the assumption? PPC64 is a RELA target and for an RELA target the implicit addend should be relied upon. AArch64.cpp masks out the bits as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81106/new/

https://reviews.llvm.org/D81106





More information about the llvm-commits mailing list