[PATCH] D81126: [PowerPC] Fix for PC Relative call protocol

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 12:35:24 PDT 2020


NeHuang marked an inline comment as done.
NeHuang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4664
 static bool
 callsShareTOCBase(const Function *Caller, SDValue Callee,
                     const TargetMachine &TM) {
----------------
Seems the assumption "calls share the same TOC base implies call does not require a toc restore" no longer hold when either caller or callee is using PCRelative addressing. Do you think it will be better to rename this function? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81126/new/

https://reviews.llvm.org/D81126





More information about the llvm-commits mailing list