[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 12 12:03:18 PDT 2020
clementval added a comment.
@jdoerfert Some tests in clang relies on the position of the specific enum in the declaration. TableGen is sorting the records so the enum is generated in alphabetical order therefore the enum position is changed. Is it fine to update the test with smith like `{{.*}}` instead of the specific id?
Example of failure: Old position 9, new position 23
./llvm-project/clang/test/AST/ast-dump-openmp-target-teams-distribute-simd.c:74:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: | | | | | `-OMPCaptureKindAttr {{.*}} <<invalid sloc>> Implicit 9
^
<stdin>:51:1: note: scanning from here
| | | | | `-OMPCaptureKindAttr 0x43ee9600 <<invalid sloc>> Implicit 23
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81736/new/
https://reviews.llvm.org/D81736
More information about the llvm-commits
mailing list