[PATCH] D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 11:26:27 PDT 2020


aardappel added a comment.

as for `auto`, indeed its says "Use auto if and only if it makes the code more readable or __easier to maintain__". That was exactly my point when I mentioned "The reason I replaced these with auto is we had a bunch of spots where we had unnecessary truncation because of a `uint32_t var = exp that results in a 64-bit value`. Using auto avoids these problems, now, and with future changes."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81704/new/

https://reviews.llvm.org/D81704





More information about the llvm-commits mailing list