[PATCH] D81685: BypassSlowDivision: Fix dropping debug info

Fri Jun 12 10:54:23 PDT 2020

arsenm marked an inline comment as done.
arsenm added inline comments.

================
Comment at: llvm/test/Transforms/CodeGenPrepare/AMDGPU/bypass-slow-div-debug-info.ll:32
+; CHECK-LABEL: @sdivrem64(
+; CHECK-NEXT:    [[TMP1:%.*]] = or i64 [[A:%.*]], [[B:%.*]], !dbg !6
+; CHECK-NEXT:    [[TMP2:%.*]] = and i64 [[TMP1]], -4294967296, !dbg !6
----------------
aprantl wrote:
> Can you replace !6 with ![[DBG:[0-9]+]]
> 
> and the CHECK that DBG is the expected location? The numbering isn't really guaranteed.
That would mean switching to handwritten checks rather than update_test_checks

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81685/new/

https://reviews.llvm.org/D81685