[PATCH] D81730: SpeculativeExecution: fix incorrect debug info move

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp:259
+  const auto AllPrecedingUsesFromBlockHoisted = [&NotHoisted](const User *U) {
+    // Debug variable has special operand to check it's not hoisted
+    if (const auto *DVI = dyn_cast<DbgVariableIntrinsic>(U)) {
----------------
Please always use full sentences with a `.` at the end in comments.


================
Comment at: llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp:268
+
+    // Debug label should not be moved
+    // TODO: possible special procesing needed to actually move label with
----------------
Could you please add a comment as to why it shouldn't be moved? That will probably be more helpful to the reader.


================
Comment at: llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp:269
+    // Debug label should not be moved
+    // TODO: possible special procesing needed to actually move label with
+    // corresponding line
----------------
processing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81730/new/

https://reviews.llvm.org/D81730