[PATCH] D81525: [Support] Ensure errs() is constructed after outs() and don't rerun tie when errs() is called

Fri Jun 12 10:21:06 PDT 2020

dblaikie added a comment.

In D81525#2089270 <https://reviews.llvm.org/D81525#2089270>, @sammccall wrote:

> @maskray sorry for turning this review thread into a mess - i was directed here but probably should rather have kept the discussions separate.
>
> Thanks for disabling the by-default behavior for the moment. If we turn it back on then the lack of the "usual thread-safety guarantees" seems like a good thing to call out in the comments.
>
> We did indeed turn this off in clangd explicitly, I'll leave that in in case we roll the default forward.

Might be worth adding a comment to describe the current state of things if that code is going to remain (with the hopes to clean it up if the current behavior sticks long-term (~weeks/months/etc))?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81525/new/

https://reviews.llvm.org/D81525