[PATCH] D81733: GlobalISel: Don't fail translate on weak cmpxchg

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 09:45:22 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:1980
+; CHECK-NEXT:    [[NEWVAL:%[0-9]+]]:_(s32) = G_CONSTANT i32 1
+; CHECK:       bb.2.repeat:
+; CHECK-NEXT:    successors: %bb.3({{[^)]+}}), %bb.2({{[^)]+}})
----------------
jfb wrote:
> arsenm wrote:
> > jfb wrote:
> > > Does this now contains two loops instead of just one?
> > No? Not sure why you think there is
> The label name is different. It's a fundamental property of weak cmpxchg that it's (mostly) used inside a user-provided loop, so it's important to make sure we don't add an inner loop when translating it.
The label name is the same, MIR functions just get bb.<blocknumber> prepended to the IR block name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81733/new/

https://reviews.llvm.org/D81733





More information about the llvm-commits mailing list