[PATCH] D80377: [flang] Google test infrastructure support for unittests

[David Truby via Phabricator via llvm-commits]

DavidTruby added inline comments.


================
Comment at: flang/CMakeLists.txt:160
+          )
+        target_link_libraries(gtest PUBLIC -lpthread)
+        add_library(gtest_main ${UNITTEST_DIR}/UnitTestMain/TestMain.cpp)
----------------
I think it's better to use CMake's find_package(Threads) support here, so that this is more likely work on platforms without pthreads.
See: https://cmake.org/cmake/help/v3.8/module/FindThreads.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377