[PATCH] D81109: llvm-link: Add support for archive files as inputs.

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin marked an inline comment as done.
jsjodin added inline comments.


================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:209
+}
+
 namespace {
----------------
mehdi_amini wrote:
> jsjodin wrote:
> > jdoerfert wrote:
> > > High level: The code is pretty "unqualified `auto`" heavy. While I guess this is neither performance critical nor too important, I would recommend to either specify some types where it might be helpful and use qualifiers, `const`, `*`, `&` where applicable.
> > I had specified some types before submitting the patch, but changed them to auto, since it looked like it was the preferred way of doing things. I can specify some types to make the code easier to follow.
> The LLVM style is supposed to avoid `auto` when the type isn't obvious from the context or it helps readability.
> https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable :  "Use auto if and only if it makes the code more readable or easier to maintain." 
Okay, thanks for pointing it out. I will update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109