[PATCH] D81743: InlineCostAnnotationPrinterPass - Introducing the pass

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D81743#2089888 <https://reviews.llvm.org/D81743#2089888>, @knaumov wrote:

> A question to @mtrofin:
>  I have changed the creation of InlineParams from
>
>   const InlineParams Params = llvm::getInlineParams();
>
>
> which invokes the creation of InlineParams with DefaultThreshold to
>
>   const InlineParams Params = llvm::getInlineParams(InlineThreshold);
>
>
> Is this correct?


I think it depends on what the goal of the pass is. If it is to capture what costs (pre- any inlining) you'd see during a run of InlinerPass, the question is which run. See PassBuilder.cpp. There are different InlineParams used, for instance, see addPGOInstrPasses, buildInlinerPipeline, and buildLTODefaultPipeline.

I suppose you could pass the InlineParameters as a ctor  parameter to the pass?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81743/new/

https://reviews.llvm.org/D81743