[PATCH] D81709: [ObjectYAML][DWARF] Let the target address size be inferred from FileHeader.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/MachOYAML.cpp:111
+  Object.DWARF.Is64bit = Object.Header.magic == MachO::MH_MAGIC_64 ||
+                         Object.Header.magic == MachO::MH_CIGAM_64;
   IO.mapOptional("LoadCommands", Object.LoadCommands);
----------------
grimar wrote:
> I am not an expert in MachO, but should MachO::FAT_MAGIC_64 and MachO::FAT_CIGAM_64 also be tested?
The Fat binary format has its own unique tag

```
--- !fat-mach-o
```

I think we don't need to worry about it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81709/new/

https://reviews.llvm.org/D81709