[PATCH] D81541: [ObjectYAML][DWARF] Implement the .debug_addr section.

Thu Jun 11 21:57:04 PDT 2020

Higuoxing added a comment.

In D81541#2086999 <https://reviews.llvm.org/D81541#2086999>, @jhenderson wrote:

> Looks mostly fine to me. How are you ensuring your section data is actually correct? Are you just verifying it against the specification/using llvm-dwarfdump/something else?

Yes, I verify it using `llvm-dwarfdump` except `segment`. `llvm-dwarfdump` cannot parse `segment` in the `.debug_addr` section.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml:243
+      SegmentSelectorSize: 0x00
+      Entries:             []
+
----------------
jhenderson wrote:
> You need a test case each for missing the version and address size fields.
`Version` is a required field, do we still need to test it here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81541/new/

https://reviews.llvm.org/D81541