[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Analysis/Presburger/Simplex.h:117
+/// and rolling back to prior snapshots. This works by maintaing an undo log
+/// of operations. Snapshots are just pointers to a particlar location in the
+/// log, and rolling back to a snapshot is done by reverting each log entry's
----------------
s/particlar/particular/


================
Comment at: mlir/include/mlir/Analysis/Presburger/Simplex.h:122
+/// Finding an integer sample is done with the Generalized Basis Reduction
+/// algorithm. See the documentation for findIntegerSample and reduceBasis.
+class Simplex {
----------------
Nice doc for the overall class! Thanks :)


================
Comment at: mlir/lib/Analysis/Presburger/Simplex.cpp:473
+
+  auto snap = getSnapshot();
+  unsigned conIndex = addRow(coeffs);
----------------
Please avoid `auto` (here and everywhere applicable) when it doesn't improve readability (`unsigned` here right?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860